Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201807753394693/task/1213390598201722?focus=true
Description
Ensure navigation works safely when optional deeplink parameters are empty by defaulting to an empty JSON object
Steps to test this PR
https://api.jsonblob.com/019c8a43-d692-7e2c-86c4-a5439d27ffdfNo UI changes
Note
Low Risk
Small, localized change to deeplink JSON deserialization behavior; only affects cases where the payload is empty.
Overview
Prevents deeplink parameter parsing crashes by treating an empty
jsonArgumentspayload as an empty JSON object when generatingtryCreateActivityParamsinContributeToActivityStarterCodeGenerator.This changes Moshi deserialization to use
deeplinkActivityParams.jsonArguments.ifEmpty { "{}" }, so optional deeplink params can be omitted without failing navigation.Written by Cursor Bugbot for commit acb488b. This will update automatically on new commits. Configure here.