X Tutup
Skip to content

Fix RMF deeplink crash for empty payload#7797

Open
nalcalag wants to merge 1 commit intodevelopfrom
feature/noelia/rmf_default_empty_json_for_additional_params
Open

Fix RMF deeplink crash for empty payload#7797
nalcalag wants to merge 1 commit intodevelopfrom
feature/noelia/rmf_default_empty_json_for_additional_params

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Feb 23, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201807753394693/task/1213390598201722?focus=true

Description

Ensure navigation works safely when optional deeplink parameters are empty by defaulting to an empty JSON object

Steps to test this PR

  • This can be tested by using https://api.jsonblob.com/019c8a43-d692-7e2c-86c4-a5439d27ffdf

No UI changes


Note

Low Risk
Small, localized change to deeplink JSON deserialization behavior; only affects cases where the payload is empty.

Overview
Prevents deeplink parameter parsing crashes by treating an empty jsonArguments payload as an empty JSON object when generating tryCreateActivityParams in ContributeToActivityStarterCodeGenerator.

This changes Moshi deserialization to use deeplinkActivityParams.jsonArguments.ifEmpty { "{}" }, so optional deeplink params can be omitted without failing navigation.

Written by Cursor Bugbot for commit acb488b. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag assigned cmonfortep and unassigned cmonfortep Feb 23, 2026
@nalcalag nalcalag changed the title Support RMF deeplinks with no payload Fix RMF deeplink crash for empty payload Feb 23, 2026
@nalcalag nalcalag marked this pull request as ready for review February 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup