Consolidate CHAT_ID_PARAM constant into DuckChatConstants

cursoragent · cursoragent · commit 18b003cd265e · 2026-03-08T20:13:25.000Z
Move the duplicated CHAT_ID_PARAM constant from three separate
companion objects into the shared DuckChatConstants object to
reduce code duplication and maintenance risk.

- RealDuckChat.kt: remove private const, add import
- DuckChatContextualViewModel.kt: remove companion object, add import
- InputScreenViewModel.kt: remove private const, add import
- DuckChatConstants.kt: add shared CHAT_ID_PARAM constant
diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/DuckChatConstants.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/DuckChatConstants.kt
@@ -19,6 +19,7 @@ package com.duckduckgo.duckchat.impl
 object DuckChatConstants {
     const val HOST_DUCK_AI = "duck.ai"
     const val JS_MESSAGING_FEATURE_NAME = "aiChat"
+    const val CHAT_ID_PARAM = "chatID"
 
     object JsResponseKeys {
         const val OK = "ok"
diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/RealDuckChat.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/RealDuckChat.kt
@@ -36,6 +36,7 @@ import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.duckchat.api.DuckAiFeatureState
 import com.duckduckgo.duckchat.api.DuckChat
 import com.duckduckgo.duckchat.api.DuckChatSettingsNoParams
+import com.duckduckgo.duckchat.impl.DuckChatConstants.CHAT_ID_PARAM
 import com.duckduckgo.duckchat.impl.DuckChatConstants.HOST_DUCK_AI
 import com.duckduckgo.duckchat.impl.clearing.DuckChatDeleter
 import com.duckduckgo.duckchat.impl.feature.AIChatImageUploadFeature
@@ -850,7 +851,6 @@ class RealDuckChat @Inject constructor(
         private const val PLACEMENT_QUERY_VALUE = "sidebar"
         private const val BANG_QUERY_NAME = "bang"
         private const val BANG_QUERY_VALUE = "true"
-        private const val CHAT_ID_PARAM = "chatID"
         private const val DEFAULT_SESSION_ALIVE = 60
         private const val REVOKE_URL = "https://duckduckgo.com/revoke-duckai-access"
     }
diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/contextual/DuckChatContextualViewModel.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/contextual/DuckChatContextualViewModel.kt
@@ -23,6 +23,7 @@ import com.duckduckgo.anvil.annotations.ContributesViewModel
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.FragmentScope
 import com.duckduckgo.duckchat.api.DuckChat
+import com.duckduckgo.duckchat.impl.DuckChatConstants.CHAT_ID_PARAM
 import com.duckduckgo.duckchat.impl.DuckChatInternal
 import com.duckduckgo.duckchat.impl.helper.DuckChatJSHelper
 import com.duckduckgo.duckchat.impl.helper.NativeAction
@@ -542,8 +543,4 @@ class DuckChatContextualViewModel @Inject constructor(
         val elapsedMs = timeProvider.currentTimeMillis() - lastClosedTimestamp
         return elapsedMs <= timeoutMs
     }
-
-    companion object {
-        private const val CHAT_ID_PARAM = "chatID"
-    }
 }
diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt
@@ -44,6 +44,7 @@ import com.duckduckgo.common.utils.SingleLiveEvent
 import com.duckduckgo.common.utils.extensions.toBinaryString
 import com.duckduckgo.duckchat.api.DuckAiFeatureState
 import com.duckduckgo.duckchat.api.DuckChat
+import com.duckduckgo.duckchat.impl.DuckChatConstants.CHAT_ID_PARAM
 import com.duckduckgo.duckchat.impl.feature.DuckChatFeature
 import com.duckduckgo.duckchat.impl.inputscreen.ui.InputScreenConfigResolver
 import com.duckduckgo.duckchat.impl.inputscreen.ui.command.Command
@@ -803,7 +804,6 @@ class InputScreenViewModel @AssistedInject constructor(
     companion object {
         const val DUCK_SCHEME = "duck"
         private const val CHAT_SUGGESTIONS_DEBOUNCE_MS = 150L
-        private const val CHAT_ID_PARAM = "chatID"
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ import com.duckduckgo.common.utils.SingleLiveEvent`
`44`	`44`	`import com.duckduckgo.common.utils.extensions.toBinaryString`
`45`	`45`	`import com.duckduckgo.duckchat.api.DuckAiFeatureState`
`46`	`46`	`import com.duckduckgo.duckchat.api.DuckChat`
	`47`	`+import com.duckduckgo.duckchat.impl.DuckChatConstants.CHAT_ID_PARAM`
`47`	`48`	`import com.duckduckgo.duckchat.impl.feature.DuckChatFeature`
`48`	`49`	`import com.duckduckgo.duckchat.impl.inputscreen.ui.InputScreenConfigResolver`
`49`	`50`	`import com.duckduckgo.duckchat.impl.inputscreen.ui.command.Command`
`@@ -803,7 +804,6 @@ class InputScreenViewModel @AssistedInject constructor(`
`803`	`804`	`companion object {`
`804`	`805`	`const val DUCK_SCHEME = "duck"`
`805`	`806`	`private const val CHAT_SUGGESTIONS_DEBOUNCE_MS = 150L`
`806`		`- private const val CHAT_ID_PARAM = "chatID"`
`807`	`807`	`}`
`808`	`808`	`}`
`809`	`809`