move log config so that logging works when detector is disabled#298
Merged
joshafeinberg merged 1 commit intodropbox:mainfrom Aug 18, 2025
Merged
Conversation
Member
|
Just curious, what would you expect to get logged when the plugin is disabled. This fix seems fine but I'm not sure if anything gets logged before this point |
Contributor
Author
|
Not sure if I would expect anything logged, but I would rather not expect the NullPointerException. ;-) |
joshafeinberg
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the detector is disabled then no logger is passed to
setupWithParamswhich leads to a NPE.I moved the logger initialization upwards and passed the logger to the method.