fix: strip HTML tags from config.name when setting page title#2690
Merged
QingWei-Li merged 1 commit intodocsifyjs:developfrom Mar 4, 2026
Merged
Conversation
The `name` config option can contain HTML markup (e.g. `<img>` tags) for rendering a logo in the sidebar. However, this raw HTML was being used directly in `document.title`, causing browser tabs to show markup like `<img src="logo.png">My Site - Page Title`. Strip HTML tags from `name` before using it in the page title so that only the plain text content appears in the browser tab. Fixes docsifyjs#2610 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Bowl42 is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameconfig option supports HTML markup (e.g.<img src="logo.png">My Site) for rendering logos in the sidebar. However, this raw HTML is also used directly as part ofdocument.title, causing the browser tab to display ugly markup like<img src="logo.png">My Site - Page Title.nameusing a regex before constructing the page title string, so only plain text content appears in the browser tab.Changes
src/core/event/index.js—onRender()method:plainNamevariable that strips HTML tags fromconfig.namevianame.replace(/<[^>]+>/g, '').trim()plainNameinstead ofnamewhen constructingcurrentTitlefordocument.titleBefore
After
Test plan
nameto a value containing HTML (e.g.<img src="logo.png"><strong>My Site</strong>)Page - My Site)nameconfig still work normallyFixes #2610
🤖 Generated with Claude Code