Add a build command accepting a tar as a InputStream, so we can build the Dockerfile TAR on the fly without a temporary folder.#9
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Jun 19, 2014
ydubreuil:build-from-tarstream
Merged
Add a build command accepting a tar as a InputStream, so we can build the Dockerfile TAR on the fly without a temporary folder.#9marcuslinke merged 1 commit intodocker-java:masterfrom ydubreuil:build-from-tarstream
marcuslinke merged 1 commit intodocker-java:masterfrom
ydubreuil:build-from-tarstream
Conversation
Contributor
|
@ydubreuil Thanks! Any chance for a test case? |
Contributor
Author
|
The best thing would be to refactor BuildImgCmd to inherit BuildImageFromStreamCmd as its code is just a cleanup of BuildImgCmd. I'm not sure how to do that properly, as the java generic model used doesn't allow inheritance of commands. Any thought ? |
Contributor
|
Hmm. Maybe we could refactor BuildImgCmd to accept both File and InputStream in its constructors. The extra code to create a stream from the file/folder could be placed in the InputStream constructor. |
…utStream, so we can build it on the fly without a temporary folder.
Contributor
Author
|
I've refactored BuildImgCmd following your idea. |
marcuslinke
added a commit
that referenced
this pull request
Jun 19, 2014
Add a build command accepting a tar as a InputStream, so we can build the Dockerfile TAR on the fly without a temporary folder.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to build a Dockerfile TAR on the fly using for example resources found in the classpath without requiring temporary copies...
I have a helper class which pipes the built TAR as a inputstream to feed this command if you are interested in.
Thanks for merging,
Yoann.