Include empty directories in build context#889
Include empty directories in build context#889KostyaSha merged 1 commit intodocker-java:masterfrom orzeh:empty-dirs-in-build-context
Conversation
pom.xml
Outdated
| <phase>process-test-resources</phase> | ||
| <configuration> | ||
| <tasks> | ||
| <!-- empty directory needed in DockerfileAddMultipleFilesTest not versioned in Git --> |
There was a problem hiding this comment.
just create directory in test new File("target/emptydir") it relative during maven test execution. TODO i plan migrate to junit and replace with @Rule
There was a problem hiding this comment.
@KostyaSha I changed that and directory is now created inside test.
|
@KostyaSha have a few of our |
|
for master no, but i can create 3.0.X branch if you can PR into two branches |
|
@KostyaSha that works! @orzeh thoughts? |
|
@cdancy @KostyaSha I can apply those changes to |
|
3.0.x open for hotfixes |
|
Awesome. Thanks again @orzeh and @KostyaSha ! |
|
Great Job. I need this Library as a part of a plugin which causes issues because of this bug. I am very happy that I can look forward to continue my work. Thanks you very much @orzeh and @KostyaSha ! |
|
When/Can version 3.0.13 now be released? |
|
@KostyaSha any chance for a new point release? |
|
i think i lost some PR, but ok. |
|
@cdancy done |
|
@KostyaSha thanks again! @MortlMcCrisis I'll put this new version through our tests and if all goes Ok plan to release |
…text Include empty directories in build context
|
@cdancy This would be nice. I have a dirty workaround in my code right now, which I would like to get rid of. |
|
@MortlMcCrisis got a bit busy at home this weekend. Just released now. Have a go and let me know if this solves your problem. |
4 participants
Listing files in build context utilized Commons IO helper method FileUtils.listFiles() which does not return empty directories. This PR implements custom method which lists files in build context also handling empty dirs.
This change is