Merged
Conversation
KostyaSha
force-pushed
the
travis1_13
branch
2 times, most recently
from
cf07323 to
086ff56
Compare
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 71.65% 71.85% +0.19%
==========================================
Files 306 306
Lines 6665 6858 +193
Branches 501 509 +8
==========================================
+ Hits 4776 4928 +152
- Misses 1597 1635 +38
- Partials 292 295 +3
Continue to review full report at Codecov.
|
As ObjectMapper expects all propeties of json content to match AuthConfig it fails on any other like "credStore" or "HttpHeaders". As only "auths" is used the json is mapped to ObjectNode so we can remove any other property. The content of this filtered node can be used as source for unmarshalling AuthConfig.
Jersey do contextual encoding and doesn’t fail. Netty impl has fair encoders, so double encoding causing docker to fail. Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com> Don’t encode filters for netty. Skip memory update. Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
This was referenced Jun 29, 2017
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
try more versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are missing tests runs against latest docker versions. Enabled travis build and trying to fix errors :(
This change is