fix(#806): filter config.json before unmarshalling#851
Closed
dleischnig wants to merge 1 commit intodocker-java:masterfrom
Closed
fix(#806): filter config.json before unmarshalling#851dleischnig wants to merge 1 commit intodocker-java:masterfrom
dleischnig wants to merge 1 commit intodocker-java:masterfrom
Conversation
As ObjectMapper expects all propeties of json content to match AuthConfig it fails on any other like "credStore" or "HttpHeaders". As only "auths" is used the json is mapped to ObjectNode so we can remove any other property. The content of this filtered node can be used as source for unmarshalling AuthConfig.
dleischnig
force-pushed
the
fix-806-invalid-auth-config
branch
from
866b5c4 to
881b5d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
+ Coverage 71.63% 71.69% +0.05%
==========================================
Files 306 306
Lines 6643 6649 +6
Branches 500 501 +1
==========================================
+ Hits 4759 4767 +8
+ Misses 1591 1590 -1
+ Partials 293 292 -1
Continue to review full report at Codecov.
|
Member
|
picked via #868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As ObjectMapper expects all propeties of json content to match AuthConfig it fails on any other
like "credStore" or "HttpHeaders". As only "auths" is used the json is mapped to ObjectNode so
we can remove any other property. The content of this filtered node can be used as source for
unmarshalling AuthConfig.
This change is