Merged
Conversation
Member
|
Let's look what happen with IT on previous versions. |
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 71.7% 71.72% +0.02%
==========================================
Files 306 306
Lines 6588 6590 +2
Branches 484 485 +1
==========================================
+ Hits 4724 4727 +3
Misses 1577 1577
+ Partials 287 286 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
Sure, 17.03 is the latest version that had old behaviour since 2015 when it was introduced. And it's changed just in 17.05 which is currently the latest unstable/edge Docker version. |
vuminhkh
added a commit
to alien4cloud/docker-java
that referenced
this pull request
Apr 30, 2017
* master-docker-java: (25 commits) Add some coding styles. Allow an explicit Dockerfile location string to be specified to the build command (docker-java#825) Proposed fix for docker-java#830 (docker-java#832) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release 3.0.9 Fix test. Update CHANGELOG.md Responce may contains token. adding support for unless-stopped restart policy Generate OSGi compliant manifest (docker-java#797) exclude commons-logging since docker-java uses slf4j/logback Unable to deserialize status response from amazon ECR login Ensure FakeDockerServer is started on a random free port Fixes docker-java#807. NettyDockerCmdExecFactory ignores API version configuration [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release 3.0.8 Update CHANGELOG.md Added healthcheck support in container inspect JSON result Use TLSv2 by default rerun failing tests count to 3 ... # Conflicts: # pom.xml
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* Proposed fix for docker-java#830 * Simplify the fix for docker-java#830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested this locally on both Docker 17.03 and 17.05.
This change is