Move slow tests to integration test phase, enable tests by default#79
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Oct 21, 2014
Merged
Move slow tests to integration test phase, enable tests by default#79marcuslinke merged 2 commits intodocker-java:masterfrom
marcuslinke merged 2 commits intodocker-java:masterfrom
Conversation
Use TestNG's test groups feature to distinguish between fast, self contained unit tests and slow integration tests that access external services. Move the latter ones to the integration test phase and disable them by default.
Contributor
|
@albers That makes sense. Please amend you PR with the appropriate changes. Thanks! |
This changes the build to a more standard Maven way.
Contributor
Author
|
done. |
albers
changed the title
Contributor
Author
|
@marcuslinke done. |
marcuslinke
added a commit
that referenced
this pull request
Oct 21, 2014
Move slow tests to integration test phase, enable tests by default
Contributor
|
@albers Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use TestNG's test groups feature to distinguish between fast, self contained unit tests and slow integration tests that access external services (
groups="integration").Move the latter ones to the integration test phase and disable them by default.
Personally, I'd prefer to have all tests enabled by default and point out to the option that you can disable the integration tests with
-DskipITsif you cannot fulfil the build requirements. If you agree, I'd like to amend this PR.