New enum "InternetProtocol" for supported IP protocols replaces "scheme"#76
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Oct 16, 2014
Merged
Conversation
The enum provides a home for parsing, stringification and the default value of the supported protocols. It also enforces the use of the more correct term "internet protocol" instead of "scheme".
Contributor
|
would the |
Contributor
Author
|
In the context of URLs, scheme is the correct word. It can represent things like http, mail, tcp and file. Here we have the distinct context of network ports like
|
Contributor
|
alright, thanks for clarification! |
marcuslinke
added a commit
that referenced
this pull request
Oct 16, 2014
New enum "InternetProtocol" for supported IP protocols replaces "scheme"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legal values for internet protocols (here known as schemes) should be defined as an enum, not as
String. This gives us type safety and some improvements in parsing and stringification.See #70,
AccessMode.In addition, scheme is a misleading name. This PR replaces it with
InternetProtocol.