X Tutup
Skip to content

Use project.build.sourceEncoding in compiler#74

Merged
marcuslinke merged 1 commit intodocker-java:masterfrom
albers:encoding
Oct 15, 2014
Merged

Use project.build.sourceEncoding in compiler#74
marcuslinke merged 1 commit intodocker-java:masterfrom
albers:encoding

Conversation

@albers
Copy link
Copy Markdown
Contributor

@albers albers commented Oct 15, 2014

Defining a default encoding of UTF-8 in project.build.sourceEncoding and
then overriding it in the compiler args with another (presumably wrong)
encoding does not make sense.
By default, <encoding> will use project.build.sourceEncoding.

@albers
Use project.build.sourceEncoding in compiler
04cd1e6 
Defining a default encoding of UTF-8 in project.build.sourceEncoding and
then overriding it in the compiler args with another (presumably wrong)
encoding does not make sense. 
By default, <encoding> will use project.build.sourceEncoding.
marcuslinke added a commit that referenced this pull request Oct 15, 2014
@marcuslinke
Merge pull request #74 from albers/encoding
51429d2 
Use project.build.sourceEncoding in compiler
@marcuslinke marcuslinke merged commit 51429d2 into docker-java:master Oct 15, 2014
@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Oct 15, 2014

@albers Thanks as always!

@albers albers deleted the encoding branch October 15, 2014 19:59
@albers
Copy link
Copy Markdown
Contributor Author

albers commented Oct 16, 2014

Thanks! That was quick.

@marcuslinke Out of context, and before I dive into deeper examination, I would like to ask whether the test suite should pass. On my systems, I constantly get these failures:

Failed tests:
testNginxDockerfileBuilder(com.github.dockerjava.core.command.BuildImageCmdImplTest):
testPullImage(com.github.dockerjava.core.command.PullImageCmdImplTest): No such image: hackmann/empty

@marcuslinke
Copy link
Copy Markdown
Contributor

marcuslinke commented Oct 16, 2014

@albers At least the testPullImage test is a known problem. Fixed it already in my local branch. Just wrap dockerClient.removeImageCmd(testImage).exec();in a try-catch block and ignore the NotFoundException. Don't have a clue what is wrong with the testNginxDockerfileBuilder...

@albers
Copy link
Copy Markdown
Contributor Author

albers commented Oct 16, 2014

I'll take a look at it. Maybe it's due to my setup. I use a remote Docker server.

@albers
Copy link
Copy Markdown
Contributor Author

albers commented Oct 16, 2014

The problem in testNginxDockerfileBuilder is specific to my environment. The Docker server is behind a firewall, which blocks direct internet access. Therefore

apt-get install -y inotify-tools nginx apache2 openssh-server

called from the container fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albers @marcuslinke
X Tutup