Improve instantiation and serialization of Bind#70
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Oct 7, 2014
Merged
Improve instantiation and serialization of Bind#70marcuslinke merged 2 commits intodocker-java:masterfrom
marcuslinke merged 2 commits intodocker-java:masterfrom
Conversation
This also changes the serialization in Binds.Serializer to always include the access mode. This is no problem in Docker API.
marcuslinke
added a commit
that referenced
this pull request
Oct 7, 2014
Improve instantiation and serialization of Bind
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers two topics:
Bind.toString()so that serializing ofBindcan be handled the same way as inVolume.isReadOnlyorisReadWrite?), a new enumAccessModewas introduced for use in theBind's constructor. This also improves parsing and serialization. The new API more closely resembles the Docker CLI syntax, which does not have a boolean notion of access mode.The boolean constructor and
Bind.isReadOnly()were kept for backwards compatibility.I would like to amend this PR to remove them, though. What do you think of this?