Use canonical form of Docker folder when building TAR files#69
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Oct 2, 2014
Merged
Use canonical form of Docker folder when building TAR files#69marcuslinke merged 1 commit intodocker-java:masterfrom
marcuslinke merged 1 commit intodocker-java:masterfrom
Conversation
In BuildImageCmdImpl#buildDockerFolderTar a canonical form of the source files referenced in the Dockerfile is used. But the Docker folder is passed in the given form to the CompressArchiveUtil. CompressArchiveUtil#relativize creates absolute TAR archive entries if the canonical form of the source files differs from the given form of the Docker folder. As a result, the Docker deamon can not find the files during the build. This can happen in case-insensitive file systems such as Windows, for example. As a solution, the canonical form of the Docker folder must be used.
marcuslinke
added a commit
that referenced
this pull request
Oct 2, 2014
Use canonical form of Docker folder when building TAR files
Contributor
|
Thanks for finding and patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
BuildImageCmdImpl#buildDockerFolderTara canonical form of the source files referenced in the Dockerfile is used. But the Docker folder is passed in the given form to theCompressArchiveUtil.CompressArchiveUtil#relativizecreates absolute TAR archive entries if the canonical form of the source files differs from the given form of the Docker folder. As a result, the Docker deamon can not find the files during the build. This can happen in case-insensitive file systems such as Windows, for example.As a solution, the canonical form of the Docker folder must be used.