Bind.parse() fails when access mode is specified#63
Merged
marcuslinke merged 3 commits intodocker-java:masterfrom Sep 28, 2014
Merged
Bind.parse() fails when access mode is specified#63marcuslinke merged 3 commits intodocker-java:masterfrom
marcuslinke merged 3 commits intodocker-java:masterfrom
Conversation
Contributor
|
@albers Thanks for your patch! Feel free to change the |
readWrite() and readOnly() both fail due to implementation errors in Bind.parse()
marcuslinke
added a commit
that referenced
this pull request
Sep 28, 2014
Bind.parse() fails when access mode is specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an off-by-one error only input without given access mode (like
/host:/container) could be parsed, see added test.Also added support for read-only (
:ro) specifications.I would also like to change the thrown exception to
IllegalArgumentExceptioninBind.parse()andVolume.parse().Is this OK, should I amend this PR with it?