Adds name filter evaluation to netty version of ListImagesCmdExec#579
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom May 12, 2016
Merged
Conversation
Previously just jaxrs had implemented the feature of filtering by image name. Even though the `withFilter` was exposed, netty's implemntation didn't checked for its presence. The commits adds a test for such feature and the correctionn to the mentioned problem.
Member
|
LGTM |
Contributor
|
Uh, nice! Can we have this... soon :))))? |
marcuslinke
changed the title
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
…e-listimages-netty Adds name filter to netty's image listing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
previously just
jaxrshad implemented the feature of filtering by image name. Even though thewithFilterwas exposed, netty's implementation didn't checked for its presence, thus, it didn't include it in the request.The PR adds a test for such feature and the correction to the mentioned problem.
Let me know if there are any issues with it,
Thx!
This change is