Add ability to configure IPAM config for CreateNetworkCmd #550
Merged
marcuslinke merged 8 commits intodocker-java:masterfrom May 12, 2016
Merged
Add ability to configure IPAM config for CreateNetworkCmd #550marcuslinke merged 8 commits intodocker-java:masterfrom
marcuslinke merged 8 commits intodocker-java:masterfrom
Conversation
Current coverage is
|
| CreateNetworkResponse createNetworkResponse = dockerClient.createNetworkCmd().withName(networkName).exec(); | ||
| Network.Ipam.Config config = new Network.Ipam.Config(); | ||
| config.setSubnet("10.67.79.0/24"); | ||
| CreateNetworkResponse createNetworkResponse = dockerClient.createNetworkCmd().withName(networkName).withIpamConfig(config).exec(); |
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.BeforeTest; | ||
| import org.testng.annotations.Test; | ||
| import org.testng.annotations.*; |
Member
There was a problem hiding this comment.
please don't use hash imports
Contributor
|
@vuminhkh Please rename tests to |
Contributor
|
@vuminhkh Thanks for contributing! |
| if (this.ipam == null) { | ||
| this.ipam = new Ipam(); | ||
| } | ||
| this.ipam.getConfig().add(config); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm fixing a minor issue in network creation API. Please let me know if it's ok for you. Thanks.
Regards,
Minh Khang VU
This change is