X Tutup
Skip to content

Fix create volume command doesn't assign passed in volume driverOpts to field#534

Merged
marcuslinke merged 1 commit intodocker-java:masterfrom
suryagaddipati:assing_driver_opts
Apr 1, 2016
Merged

Fix create volume command doesn't assign passed in volume driverOpts to field#534
marcuslinke merged 1 commit intodocker-java:masterfrom
suryagaddipati:assing_driver_opts

Conversation

@suryagaddipati
Copy link
Copy Markdown
Contributor

This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Current coverage is 23.70%

Merging #534 into master will decrease coverage by -0.01% as of 42fb670

@@            master   #534   diff @@
=====================================
  Files          295    295       
  Stmts         6102   6103     +1
  Branches       530    530       
  Methods          0      0       
=====================================
  Hit           1447   1447       
  Partial         85     85       
- Missed        4570   4571     +1

Review entire Coverage Diff as of 42fb670

Powered by Codecov. Updated on successful CI builds.

@KostyaSha
Copy link
Copy Markdown
Member

is netty impl ok?

@suryagaddipati
Copy link
Copy Markdown
Contributor Author

hi @KostyaSha I am not quite sure what netty impl is but seems to (functionally) work fine in the project I am using this library.

@marcuslinke marcuslinke merged commit 651d68f into docker-java:master Apr 1, 2016
@marcuslinke
Copy link
Copy Markdown
Contributor

LGTM, so merging.

@marcuslinke marcuslinke added this to the 3.0.0-RC5 milestone Apr 1, 2016
@marcuslinke marcuslinke changed the title Assign passed in volume opts to field Fix create volume command doesn't assign passed in volume driverOpts to field Apr 8, 2016
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
…opts

Assign passed in volume opts to field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup