X Tutup
Skip to content

Added shmsize build option#533

Merged
KostyaSha merged 2 commits intodocker-java:masterfrom
alemousist:master
Apr 8, 2016
Merged

Added shmsize build option#533
KostyaSha merged 2 commits intodocker-java:masterfrom
alemousist:master

Conversation

@alemousist
Copy link
Copy Markdown

Added shmsize (Size of /dev/shm in bytes) on imagebuild as described in Docker API 1.22


This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Current coverage is 23.68%

Merging #533 into master will decrease coverage by -0.03% as of e4bb095

@@            master    #533   diff @@
======================================
  Files          295     295       
  Stmts         6102    6109     +7
  Branches       530     532     +2
  Methods          0       0       
======================================
  Hit           1447    1447       
  Partial         85      85       
- Missed        4570    4577     +7

Review entire Coverage Diff as of e4bb095

Powered by Codecov. Updated on successful CI builds.

@KostyaSha
Copy link
Copy Markdown
Member

@alemousist
Copy link
Copy Markdown
Author

@KostyaSha ,
The shmsize option appeared in the latest version (v1.22) of the remote api.
I've adapted code to the project code style/design.
Thanks!

@marcuslinke
Copy link
Copy Markdown
Contributor

LGTM @KostyaSha ?

@marcuslinke marcuslinke added this to the 3.0.0-RC5 milestone Apr 1, 2016
@KostyaSha
Copy link
Copy Markdown
Member

but there is no test :(

@marcuslinke
Copy link
Copy Markdown
Contributor

Integration test will be difficult... How this could be tested?

@KostyaSha
Copy link
Copy Markdown
Member

@marcuslinke for non cmd

assertThat(inspectImage, equalTo(inspectImageResponse));

ensures that class matches data after serder + builder/equals ensures that everything is matching and reproducible :)

@marcuslinke
Copy link
Copy Markdown
Contributor

@KostyaSha This field is not serialized to json, so serder test will not work.

@KostyaSha
Copy link
Copy Markdown
Member

You have the field and it sends to docker daemon as request. Url parameter is only untestable without integration.

@marcuslinke
Copy link
Copy Markdown
Contributor

Sorry, not sure what you mean...

@KostyaSha
Copy link
Copy Markdown
Member

@marcuslinke all *Cmd classes corresponds to request objects. For docker daemon result of *cmd execution is just json (request) that sent to daemon. You can dump it and i want serialise/deserialise request data to class directly. Atm i can't do this because all *Cmd classes has constructor, because cmd contains request data and execution logic (code that do request). As i understand initially in this library *Cmd was only the execution method that allowed set request data.
Tied data to request code allows make fluent and shorter library calls.

@KostyaSha
Copy link
Copy Markdown
Member

LGTM @KostyaSha ?

LGTM

@KostyaSha KostyaSha merged commit a2cde4f into docker-java:master Apr 8, 2016
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup