Fix exec start stdin encoding#466
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Feb 16, 2016
Merged
Conversation
Member
|
Is it only netty issue? |
Contributor
Author
|
Yes, netty-only. As I understood jaxrs-based implementation doesn't support stdin at all. |
Member
|
Ah, right! |
marcuslinke
added a commit
that referenced
this pull request
Feb 16, 2016
Fix exec start stdin encoding
Contributor
|
@rtimush Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdin is now encoded like this:
abc->\0\0\0a\0\0\0b\0\0\0c. This works with/bin/sh, but doesn't work with other commands.This pull request removes stream re-encoding and sends the InputStream directly to channel.