Made the client swarm-compatible#443
Made the client swarm-compatible#443ottes wants to merge 6 commits intodocker-java:masterfrom ottes:master
Conversation
|
oh, i just saw the other pull requests... sorry for duplicated stuff.... but all i wrote, was written weeks ago, i just wanted to give back stuff |
|
another thing => if i would be able to retrieve the value of isSwarmEndpoint inside the PullImageResultItem, the check for " downloaded" could be better also the "Cast Info to SwarmInfo" thing could be better i guess |
|
By when do you guys plan to release Snapshot 3.0.0 into maven. |
|
@xFragger What we need for swarm related changes is an integration test case. See #337 please for a proposal. I've currently no time for implementing a setup as described there. Feel free to provide an PR with an integration test setup and we can start to merge swarm related things into master. @KostyaSha : Do you agree? |
|
@sray7965 I'm planning to release v3.0.0 until 15th of february. |
|
@marcuslinke i would prefer to split integration tests into separate module and reorganise to multi-module before. |
|
@KostyaSha Makes sense. 👍 |
|
Related to issue #395 |
| private String status; | ||
|
|
||
| @JsonIgnore | ||
| private String name; |
There was a problem hiding this comment.
if it temp, then should be transient
- reverted arraychecking in PullResponseItem
# Conflicts: # src/main/java/com/github/dockerjava/core/DockerClientConfig.java # src/test/java/com/github/dockerjava/core/DockerClientConfigTest.java
|
Well.... look like it works... but one problem => had to hardcode the TLS Stuff, any ideas how to do this better? |
| private static final String IMAGE_UP_TO_DATE = "Image is up to date"; | ||
|
|
||
| private static final String DOWNLOAD_COMPLETE = "Download complete"; | ||
| private static final String SWARM_DOWNLOADED = " downloaded"; //Swarm sends another text, when download is complete! |
|
Could you check whether master contains this functionality? |
4 participants
Tested what i was able to test. Didn't manage to create a swarm inside the test-suite, so an integration test of all this is missing atm.
Please discuss, i will make all suggested and useful changes, in 2 weeks at the latest.
This change is