Add aux to ResponseItem for API 1.22#442
Closed
marcust wants to merge 1 commit intodocker-java:masterfrom
Closed
Conversation
marcust
pushed a commit
to alexec/docker-java-orchestration
that referenced
this pull request
Jan 28, 2016
Member
There was a problem hiding this comment.
please set since javadocs tags
Contributor
|
@marcust Thanks. Will merge after v3.0.0 is released. |
As mentioned in Issue docker-java#437
marcust
force-pushed
the
feature/add_aux_response
branch
from
a3d58c6 to
286731a
Compare
Member
|
@marcuslinke as soon as you end your refactorings i plan resolve #404 with reviewing newer API. Let me know when you end. |
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public static class AuxDetail implements Serializable { | ||
| private static final long serialVersionUID = -9136704865403084084L; |
Member
There was a problem hiding this comment.
Member
|
I will pick this into 1.22 branch. I think i we will keep it open until all tests will be added before real master merge. |
Closed
Member
|
Can't reproduce "aux" field on 1.10.2 daemon... |
Member
|
maybe it only on secured daemons https://github.com/docker/docker/blob/2892de760f412360c5effef9cfc346f2d92eaa4c/pkg/progress/progress.go#L19-L21 |
Member
|
@marcust could you provide some dump of this pull response? |
Member
|
Merged, but json sample would be welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #437
This change is