X Tutup
Skip to content

Refactored filters API#426

Merged
marcuslinke merged 1 commit intomasterfrom
rebased-refact-filters
Jan 18, 2016
Merged

Refactored filters API#426
marcuslinke merged 1 commit intomasterfrom
rebased-refact-filters

Conversation

@marcuslinke
Copy link
Copy Markdown
Contributor

This PR eleminates the use of the generic Filters object in the command APIs.

@KostyaSha
Copy link
Copy Markdown
Member

You can force push to existed branch + previous PR was mergeable.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collections.notEmpty() or something from guava that already do null check?

marcuslinke added a commit that referenced this pull request Jan 18, 2016
@marcuslinke marcuslinke merged commit fc9fb32 into master Jan 18, 2016
@marcuslinke marcuslinke deleted the rebased-refact-filters branch January 18, 2016 20:59
@KostyaSha
Copy link
Copy Markdown
Member

You are merging faster than i'm reviewing.

@marcuslinke
Copy link
Copy Markdown
Contributor Author

@KostyaSha Sorry, I thought you reviewed original PR already.

@KostyaSha
Copy link
Copy Markdown
Member

But new commits periodically appears new :)

@KostyaSha
Copy link
Copy Markdown
Member

Note, for any null/empty/string length try search for helpers in guava/commons/collections.
With java 1.8 Objects.isNull() Obects.nonNull() will be available that will end to nicer code

if (isNull(someObject)) {

or

  public void someMethod(String arg) {
      Objects.requireNonNull("Fail", arg);

But null check from 1.8 doesn't catched by findbugs yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup