Introduce InspectContainerResponse.Mounts #392
Merged
marcuslinke merged 4 commits intomasterfrom Dec 8, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
Should it be changed to RemoteApiVersion object?
Contributor
Author
There was a problem hiding this comment.
That would make sense. Will do as suggested.
Contributor
Author
There was a problem hiding this comment.
Seems thats not that simple. RemoteApiVersion is not used by DockerClientConfigBuilder so far. So leaving this for separate PR.
Member
There was a problem hiding this comment.
Sounds like it should be RW and RO (upper case)
Contributor
Author
There was a problem hiding this comment.
Ooops. I fear it's too late now. This one must be a String.
Member
There was a problem hiding this comment.
btw, maybe better AssertThat(..., equalTo(...)) ?
marcuslinke
added a commit
that referenced
this pull request
Dec 8, 2015
Introduce InspectContainerResponse.Mounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which fixes issue #388