Adding support for withPidMode #332#333
Merged
marcuslinke merged 5 commits intodocker-java:masterfrom Sep 29, 2015
sashkachan:master
Merged
Adding support for withPidMode #332#333marcuslinke merged 5 commits intodocker-java:masterfrom sashkachan:master
marcuslinke merged 5 commits intodocker-java:masterfrom
sashkachan:master
Conversation
Member
There was a problem hiding this comment.
@marcuslinke do you need at all this huge constructor?
Contributor
There was a problem hiding this comment.
Nope. Not needed. It's already removed in 'issue-246' branch. So no need to remove it here.
added 2 commits
September 28, 2015 17:12
Member
There was a problem hiding this comment.
@CheckForNull here also required as it doesn't inherited by any interfaces
Author
|
I think all issues but humongous constructor were addressed. Let me know if I missed anything. |
Contributor
|
Thanks for your contribution! Hopefully I'm able to merge this evening. |
There was a problem hiding this comment.
If you want to reflect the CLI, it should be withPid(String pidMode):
--pid= PID namespace to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.