Support "since" field for logs command.#320
Conversation
|
Looking at the check failures, it doesn't seem they were caused by this particular change. |
|
No worries about the failing tests. But I would like to ask for a test case for your PR. |
|
absolutely, I don't know why the I didn't find the existing LogContainerCmdImplTest before I submitted this PR... |
|
Added the test, here is the output from the test when I run the test locally: 23:15:35.288 DEBUG c.g.d.jaxrs.DockerCmdExecFactoryImpl - 19 * Sending client request on thread pool-72-thread-1 23:15:35.289 DEBUG o.a.h.i.c.PoolingHttpClientConnectionManager - Connection request: [route: {s}->https://192.168.99.100:2376][total kept alive: 2; route allocated: 2 of 2; total allocated: 2 of 20] |
|
Seems like "since" field is introduced in the remote API 1.19. I didn't find the "since" in API 1.18 The test for "since" pass on my local machine, where it has: For the failed test on ci/circleci, it has: The API version difference explains why. Also worth mentioning that adding the since field is a no-op for apiVersion < 1.19. How do you suggest handling the dependency? |
|
As stated in the README.md the current docker-java release version supports docker remote API > v1.19, so this will be no problem. As CircleCI uses a quite old docker version I will disable it soon. |
|
Great! Let me know if there is anything else I need to do to get it to a mergable state from your point of view. |
|
Thanks for your contribution! |
No description provided.