Respect exception rules in .dockerignore file while build images#301
Merged
marcuslinke merged 3 commits intomasterfrom Aug 19, 2015
Merged
Respect exception rules in .dockerignore file while build images#301marcuslinke merged 3 commits intomasterfrom
marcuslinke merged 3 commits intomasterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
Good catch. Thanks!
added 2 commits
August 19, 2015 23:42
Member
|
Don't know details, but change LGTM |
Contributor
Author
|
I tried to squash it but did something wrong. Changes are in master now but contained in a new commit, so I will close this PR. OK? |
Member
|
I usually do rebase -i HEAD~5' and then mark as |
Member
|
I don't see commits in master, just merge this PR? |
marcuslinke
added a commit
that referenced
this pull request
Aug 19, 2015
Respect exception rules in .dockerignore file while build images
Contributor
Author
|
Hmmm. Merge contains no changes. However, next time i will be more carefully. Commit is here: 33fdd71 |
Member
|
It is, GH sort history by date. And if there is no changes in PR (i.e. merged in other way) GH automatically detect it and marks as merged/closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect exception rules like "!Dockerfile" in .dockerignore file while building images. See https://docs.docker.com/reference/builder/#dockerignore-file for details.