Makes Config a public, immutable class with a builder#29
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Jul 29, 2014
Merged
Makes Config a public, immutable class with a builder#29marcuslinke merged 1 commit intodocker-java:masterfrom
marcuslinke merged 1 commit intodocker-java:masterfrom
Conversation
This makes Config a public class, so it can be passed into the DockerClient constructor from code in different packages. It also makes Config an immutable object and includes a builder for convenience. Fixes issue docker-java#24.
marcuslinke
added a commit
that referenced
this pull request
Jul 29, 2014
Makes Config a public, immutable class with a builder
Contributor
|
@mfulgo Thanks for your contribution! I was in vacation for a while so sorry for late reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Config a public class, so it can be passed into the
DockerClient constructor from code in different packages. It also
makes Config an immutable object and includes a builder for convenience.
Fixes issue #24.