Added GZIP compression for build context creation#284
Merged
marcuslinke merged 2 commits intomasterfrom Jul 30, 2015
Merged
Conversation
|
This PR is a fix for #283. |
Member
There was a problem hiding this comment.
i think you need somewhere wrap try with resources
Member
There was a problem hiding this comment.
just wrap as
try (TarArchiveOutputStream tos = new TarArchiveOutputStream(new GZIPOutputStream.. ... )) {
main code
}
and remove finally.close, AFAIR tos may become null and then you will have NPEs, try-with-resources should save you.
Contributor
Author
There was a problem hiding this comment.
Thanks! Will do so.
marcuslinke
added a commit
that referenced
this pull request
Jul 30, 2015
Added GZIP compression for build context creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.