Added ReadonlyRootfs option.#245
Added ReadonlyRootfs option.#245marcuslinke merged 1 commit intodocker-java:masterfrom scadgek:master
Conversation
|
@scadgek Thanks for contributing! |
There was a problem hiding this comment.
Can't this cause problems when property wouldn't exist? Boolean will default to null, while boolean may report false negative 'false'.
There was a problem hiding this comment.
Good point. I think we should change all json mapped boolean fields into Boolean in a separate refactoring.
There was a problem hiding this comment.
I just interesting because i see inconsistency everywhere. Maybe document somewhere DESIGN.md ?
There was a problem hiding this comment.
What inconsistencies did you find. Some examples?
There was a problem hiding this comment.
boolean vs Boolean in other places, but i may mistake.
There was a problem hiding this comment.
Well, in this case a default boolean = false will be ok as long as ReadonlyRootfs option is false by default. I think it'll we better to add default values in such classes corresponding to docker defaults, than creating objects and handling nulls in several places.
There was a problem hiding this comment.
Best will be to use object types instead of primitives. See #246
3 participants
No description provided.