X Tutup
Skip to content

Fixes for startContainerCmd#22

Merged
marcuslinke merged 5 commits intodocker-java:masterfrom
NirmataOSS:master
Jul 15, 2014
Merged

Fixes for startContainerCmd#22
marcuslinke merged 5 commits intodocker-java:masterfrom
NirmataOSS:master

Conversation

@patelrit
Copy link
Copy Markdown
Contributor

Fixed issues with startContanerCmd and updated test case

  • Set accept header to Json
  • Added defensive null check for content-type
  • Use 'top' command so container doesnt exit immediately

patelrit added 5 commits July 14, 2014 10:01
The accept header was being set incorrectly to text instead of json.
Also added a defensive null check in JsonClientFilter.
Using top command instead of true so that the container keeps running
and returns the valid state
The accept header was being set incorrectly to text instead of json.
Also added a defensive null check in JsonClientFilter.
Conflicts:

src/test/java/com/github/dockerjava/client/command/StartContainerCmdTest
.java
Fix merge issue
marcuslinke added a commit that referenced this pull request Jul 15, 2014
Fixes for startContainerCmd
@marcuslinke marcuslinke merged commit 351dac1 into docker-java:master Jul 15, 2014
@marcuslinke
Copy link
Copy Markdown
Contributor

@patelrit Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup