Allow for null bindings#197
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Apr 28, 2015
chenchun:binding
Merged
Conversation
Contributor
|
@chenchun Null bindings simply indicates that there was no binding at all. As it is impossible to modify bindings of an already created container there should be no need for this patch. Or am I missing something here? |
Contributor
Author
|
@marcuslinke you are right, it means no binding. I think even if the value is null, it doesn't mean the key is useless. I create this PR cause I need these keys of "Ports" even if the values is null. Besides I think docker-java client should respect the format which docker daemon describes the container, make sense ? |
Contributor
Author
|
Thanks very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null bindings is possible, see the following example.