Add missing options to BuildCmd and set them to match Docker client.#19
Merged
marcuslinke merged 2 commits intodocker-java:masterfrom Jul 9, 2014
Merged
Add missing options to BuildCmd and set them to match Docker client.#19marcuslinke merged 2 commits intodocker-java:masterfrom
marcuslinke merged 2 commits intodocker-java:masterfrom
Conversation
marcuslinke
added a commit
that referenced
this pull request
Jul 9, 2014
Add missing options to BuildCmd and set them to match Docker client.
Contributor
|
@sfitts Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the Docker client's build command will set the
--rmoption totrueso that intermediate containers are cleaned up once the build completes. This is useful since it avoids cluttering up the list of stopped containers. I noticed this after I switched gradle-docker to use the API instead of the command line client, so I wanted to bring the two in line. The API supports this option, so I added it toBuildImgCmd.javawith a default setting oftrue.The build API also supports a
-qoption which can be used to suppress output. By default this isfalse. This option was added as well.