Merged
Conversation
Linking is now available through StartContainerCmd
Contributor
|
@elektro-wolle Thank you for your contribution! It would be nice to have a test case for this. Any chance? |
Author
|
I've tried to built a testcase but unfortunately the inspect command does not retrieve the current links. This is fixed in the docker remote-api v.1.13 (https://docs.docker.com/reference/api/docker_remote_api/#whats-new) but I'm currently stuck to a previous version. |
Contributor
|
@elektro-wolle I currently work on v.1.13 compatibility. So i will write a simple test case myself and merge your commits into master afterwards. |
Contributor
|
@elektro-wolle I've written a simple test now. See StartContainerCmdTest. Maybe we could use your Links class in ContainerInspectResponse.HostConfig.Links sometimes also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking is now available through StartContainerCmd