Add SwarmNodeStatus address field#1405
Merged
bsideup merged 2 commits intodocker-java:masterfrom Jun 1, 2020
missmoode:master
Merged
Add SwarmNodeStatus address field#1405bsideup merged 2 commits intodocker-java:masterfrom missmoode:master
bsideup merged 2 commits intodocker-java:masterfrom
missmoode:master
Conversation
bsideup
reviewed
Jun 1, 2020
docker-java-api/src/main/java/com/github/dockerjava/api/model/SwarmNodeStatus.java
Outdated
Show resolved
Hide resolved
bsideup
approved these changes
Jun 1, 2020
Member
bsideup
left a comment
bsideup
left a comment
There was a problem hiding this comment.
I added a minor javadoc fix, but otherwise looks good 👍
…SwarmNodeStatus.java
Member
|
@missmoode thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Addr field found in
/nodes/{id}'sstatusobject.I've not made a Pull Request before, so apologies if I've made a mistake here.