Merged
Conversation
KostyaSha
commented
Mar 3, 2020
| * @see https://docs.docker.com/engine/reference/api/docker_remote_api_v1.21/#attach-to-a-container | ||
| * @see https://docs.docker.com/engine/reference/api/docker_remote_api_v1.21/#exec-start | ||
| */ | ||
| public class NettyDockerCmdExecFactory extends AbstractDockerCmdExecFactory implements DockerCmdExecFactory { |
KostyaSha
commented
Mar 3, 2020
| clientBuilder.connectTimeout(connectTimeout, TimeUnit.MILLISECONDS); | ||
| } | ||
|
|
||
| clientBuilder.retryOnConnectionFailure(true); |
Member
Author
There was a problem hiding this comment.
questionable, better move to option?
KostyaSha
force-pushed
the
okhttp-timeouts
branch
from
48d1fcd to
3a8140b
Compare
KostyaSha
force-pushed
the
okhttp-timeouts
branch
from
3a8140b to
ce1fe66
Compare
bsideup
requested changes
Mar 4, 2020
| private DockerClientConfig dockerClientConfig; | ||
|
|
||
| protected Integer connectTimeout; | ||
| protected Integer readTimeout; |
Member
There was a problem hiding this comment.
readTimeout is wrong since there can be long living connections. The correct approach would be to use timeouts/deadlines when executing the commands
Member
Author
There was a problem hiding this comment.
For library that doesn't matter, you can set any timeouts on your app side.
Member
There was a problem hiding this comment.
you should not be setting the default read timeout here. Some operations last minutes or even hours. The callee should set the timeouts at the use site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is