Unixsocket support#125
Unixsocket support#125marcuslinke merged 4 commits intodocker-java:masterfrom gesellix-docker:unixsocket-rebased
Conversation
|
Just for the record I'd like mention that @alexkamp initially created the code in gesellix-docker/docker-java@a230b21 and only contains some modifications to make ssl work with the ApacheConnector. |
|
@gesellix Sadly i can't get all integration tests running with it. |
|
@marcuslinke in which environment? http, https, boot2docker, unix? ... too many choices ;) can you post a stacktrace? |
|
@gesellix Oh, sorry. I meant testing against boot2docker/MacOS with https connection. |
|
This may due to latest changes as i merged your branch locally. Maybe i'm able to investigate this in the evening... |
|
@marcuslinke if you prefer, I can apply another rebase/squash based on the current master. I can investigate this evening, too, but I would prefer if you could try on your environment (boot2docker/mac/https). |
|
@marcuslinke looks like it's only an InputStream which isn't fully read in a test... I'm going to apply a fix and cleanup this PR |
…fig. other changes: - make all unit tests succeed on Windows - only create a container when needed - read the complete response when copying a file from a container
|
@marcuslinke you can try again, now. |
|
I like to see this PR getting merged. I have ubuntu runnig with docker over https and socket in case you need another environment to run the integration tests on |
|
@marcuslinke The same hanging build? does it run, when you run it as the only test, i.e. with the mvn parameter |
|
@gesellix Right. It hangs even when running as single test:
Looking with jconsole shows the following: |
|
After some minutes of hanging there appears
|
|
@marcuslinke thanks, I'll try to reproduce it... Would you like to try another way of building the project? I added a Dockerfile, which works on my machine as follows (you'll need to add the username, password, and email as env parameter): Builds in that Docker image still work on my machine. |
|
@marcuslinke I made another try to build the project on boot2docker-windows w/ https - with success. It looks like it's a Mac specific issue, which might possibly go away when you try to run the Dockerfile. I'll ask my collegues next week to give it a try. |
|
@marcuslinke regarding the strange message after the hanging build, see this entry at StackOverflow and the links in its comments. It doesn't seem to be the reason for the hanging build, though. |
|
OK, I checked out the branch from gesellix and ran the integration tests. They pass using both https and socket. Here are the .docker.io.properties files I used for running the tests: Https: Socket: |
|
in the very first try I didn't specify the url. I only specify username, password, and email. With this setup the following two tests were failing
After I added the url (first https afterwards socket) all tests were green. What is even stranger is, that removing the url did not make the tests fail again. So I assume this may have something todo with the state of my user in the docker hub. I created a new user for running the integration tests... the error was something like the following: could not remove container . No such process exists. (ResponseStatusExceptionFilter.java:48) |
|
@gesellix Building the project from within docker does not work out of the box: |
|
The whole problem seems to be with threading. Disabling one of the two testcases in |
|
Just a question on the side. Are the integration tests run on travis or any other CI platform? |
|
@marcuslinke I asked a collegue to check on his Mac/boot2docker installation, I'll probably get results tomorrow or on Wednesday. |
|
Now it becomes interesting... here the results of another Mac - no hanging build: Environment:
The only obvious difference to me is the Java version. Since I've tested it on a non-developer Mac, I made a fresh JDK install. |
|
The relevant logs for |
|
@gesellix Thanks for your investigations. I will try to build with the very same jdk version this evening. |
|
@marcuslinke I guess it would also be interesting to know which/how much events are received by which test. |
|
@gesellix OK. I will report. Btw., whats the version of boot2docker / docker in your environment? |
|
@marcuslinke the most recent 1.4.1 (in all variants like native linux, boot2docker-windows, boot2docker-mac). |
|
@gesellix Yeah! With latest jdk and boot2docker/docker versions tests run fine now. Thanks for all of your effort! So it's time for a merge i guess... |
|
@marcuslinke you have no idea how glad I am for this to be finally merged ;-) |
3 participants
No description provided.