Command resource cleanup after command execution#120
Merged
marcuslinke merged 1 commit intodocker-java:masterfrom Jan 7, 2015
Merged
Command resource cleanup after command execution#120marcuslinke merged 1 commit intodocker-java:masterfrom
marcuslinke merged 1 commit intodocker-java:masterfrom
Conversation
Contributor
|
@tedoc2000 Thanks for the hint and your contribution first. But maybe we should introduce a more generic concept of a resource cleanup after command execution instead? Something like |
Contributor
Author
|
Sounds good.. Let me redo this pull request. |
DockerCmd<T> now extends java.io.Closeable. This allows us to cleanup the
temporary tar file created when DockerClient.buildImageCmd(File)
is invoked.
Code would look like:
BuildImageCmd cmd = dockerClient.buildCmd(myDir);
try {
// ..
// cmd.exec();
// ...
} finally {
cmd.close();
}
Contributor
Author
|
Okay updated.. |
Contributor
|
@tedoc2000 Thanks for your effort! |
marcuslinke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems important to be able to do this.. Let me know if you want this to be the default.