X Tutup
Skip to content

Downgraded jackson-jaxrs dependency version#102

Merged
marcuslinke merged 1 commit intodocker-java:masterfrom
omniproc:patch-1
Dec 2, 2014
Merged

Downgraded jackson-jaxrs dependency version#102
marcuslinke merged 1 commit intodocker-java:masterfrom
omniproc:patch-1

Conversation

@omniproc
Copy link
Copy Markdown

For better compatibility in jar-conflict szenarios I'd like to suggest to use jackson 2.1.2 as it seems that no 2.3.3 methods are in use yet.

For better compatibility in jar-conflict szenarios I'd like to suggest to use jackson 2.1.2 as it seems that no 2.3.3 methods are in use yet.
@marcuslinke
Copy link
Copy Markdown
Contributor

@M451 Could you explain 'better compatibility' please?

@omniproc
Copy link
Copy Markdown
Author

@marcuslinke

I'm using this lib for a os project that integrates into another project which is using jackson 2.1.2. Since 2.1.2 is loaded in the parent classloader, docker-java's 2.3.3 dependency is never loaded and 2.1.2 is used. This results in an "method not found" exception for some operations such as pull and start when getFactory of jackson's fasterxml is called.

Since there is no hard requirement for 2.3.3 within the docker-java project itself, I'd suggest to use lower dependency versions if possible to maximize compability in such dependency conflict szenarios (also known as jar hell) - most libs are compatible with their predecessor versions but not vice-versa.

I know this is a very special case but I reluctantly would like to fork just in order to get this lib running.

@albers
Copy link
Copy Markdown
Contributor

albers commented Nov 26, 2014

Maybe this is related: https://issues.jenkins-ci.org/browse/JENKINS-25692

@omniproc
Copy link
Copy Markdown
Author

@albers

I guess it's the same issue but with another dependency. That's why I'd like to suggest to use dependency versions as high as required but as low as possible.

@marcuslinke
Copy link
Copy Markdown
Contributor

@M451 Thanks for the explanation. I will try to integrate this in the next few days.

@omniproc
Copy link
Copy Markdown
Author

omniproc commented Dec 2, 2014

@marcuslinke
can you tell me the status on this? Do you think you could merge atleast this dep. into the project so it's included within the latest snapshot?

marcuslinke added a commit that referenced this pull request Dec 2, 2014
Downgraded jackson-jaxrs dependency version
@marcuslinke marcuslinke merged commit d2d9744 into docker-java:master Dec 2, 2014
@marcuslinke
Copy link
Copy Markdown
Contributor

@M451 Merged. Thanks! I will publish a new release probably next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup