X Tutup
Skip to content

withHostConfig should not override instance #258

@lordofthejars

Description

@lordofthejars

Currently if you call withHostConfig method (

public CreateContainerCmd withHostConfig(HostConfig hostConfig) {
) you are unsetting previous values. Since you can set then directly from CreateBuilder or withHostConfig it seems not a good decision to override them so I suggest that instead of overriding it simply appends.

The other option is that all options that appear from hostconfig can be also set from Container builder. For example readOnlyRootFs cannot be set

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      X Tutup