Add support for deleting temporary temp files

tedoc2000 · tedoc2000 · commit f0e78bdafd77 · 2015-01-07T07:56:23.000-08:00
DockerCmd&lt;T&gt; now extends java.io.Closeable. This allows us to cleanup the
temporary tar file created when DockerClient.buildImageCmd(File)
is invoked.

Code would look like:

BuildImageCmd cmd = dockerClient.buildCmd(myDir);
try {
  // ..
  // cmd.exec();
  // ...
} finally {
  cmd.close();
}
diff --git a/src/main/java/com/github/dockerjava/api/command/DockerCmd.java b/src/main/java/com/github/dockerjava/api/command/DockerCmd.java
@@ -1,6 +1,8 @@
 package com.github.dockerjava.api.command;
 
-public interface DockerCmd<RES_T> {
+import java.io.Closeable;
+
+public interface DockerCmd<RES_T> extends Closeable {
 
 	public RES_T exec();
 
diff --git a/src/main/java/com/github/dockerjava/core/command/AbstrDockerCmd.java b/src/main/java/com/github/dockerjava/core/command/AbstrDockerCmd.java
@@ -1,5 +1,7 @@
 package com.github.dockerjava.core.command;
 
+import java.io.IOException;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -25,4 +27,7 @@ public RES_T exec() throws DockerException {
 		LOGGER.debug("Cmd: {}", this);
 		return execution.exec((CMD_T)this);
 	}
-}
+
+    @Override
+	public void close() throws IOException {}
+}
diff --git a/src/main/java/com/github/dockerjava/core/command/BuildImageCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/BuildImageCmdImpl.java
@@ -40,6 +40,7 @@ public class BuildImageCmdImpl extends AbstrDockerCmd<BuildImageCmd, InputStream
 			.compile("^ENV\\s+(.*)\\s+(.*)$");
 
 	private InputStream tarInputStream = null;
+	private File tarFile = null;
 	private String tag;
 	private boolean noCache;
 	private boolean remove = true;
@@ -48,7 +49,13 @@ public class BuildImageCmdImpl extends AbstrDockerCmd<BuildImageCmd, InputStream
 	public BuildImageCmdImpl(BuildImageCmd.Exec exec, File dockerFolder) {
 		super(exec);
 		Preconditions.checkNotNull(dockerFolder, "dockerFolder is null");
-		withTarInputStream(buildDockerFolderTar(dockerFolder));
+		tarFile = buildDockerFolderTar(dockerFolder);
+		try {
+			withTarInputStream(FileUtils.openInputStream(tarFile));
+		} catch (IOException e) {
+			// we just created the file this should never happen.
+			throw new RuntimeException(e);
+		}
 	}
 
 	public BuildImageCmdImpl(BuildImageCmd.Exec exec, InputStream tarInputStream) {
@@ -129,6 +136,14 @@ public BuildImageCmdImpl withQuiet(boolean quiet) {
 		return this;
 	}
 
+	@Override
+	public void close() throws IOException {
+		super.close();
+		if (tarFile != null) {
+			FileUtils.deleteQuietly(tarFile);
+		}
+	}
+
 	@Override
 	public String toString() {
 		return new StringBuilder("build ")
@@ -139,7 +154,7 @@ public String toString() {
 				.toString();
 	}
 
-	protected InputStream buildDockerFolderTar(File dockerFolder) {
+	protected File buildDockerFolderTar(File dockerFolder) {
 		Preconditions.checkArgument(dockerFolder.exists(),
 				"Path %s doesn't exist", dockerFolder);
 		Preconditions.checkArgument(dockerFolder.isDirectory(),
@@ -255,9 +270,8 @@ protected InputStream buildDockerFolderTar(File dockerFolder) {
 				}
 			}
 
-			dockerFolderTar = CompressArchiveUtil.archiveTARFiles(dockerFolder,
+			return CompressArchiveUtil.archiveTARFiles(dockerFolder,
 					filesToAdd, archiveNameWithOutExtension);
-			return FileUtils.openInputStream(dockerFolderTar);
 		} catch (IOException ex) {
 			FileUtils.deleteQuietly(dockerFolderTar);
 			throw new DockerClientException(
