This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.06] Set BuildKit's ExportedProduct variable to show useful errors in the future#21
Merged
andrewhsu merged 3 commits intodocker-archive:18.06from Aug 7, 2018
Merged
Conversation
Member
|
Build is failing; |
tiborvass
force-pushed
the
18.06-vendor-buildkit
branch
from
b16cc40 to
046e3a5
Compare
tiborvass
changed the title
tiborvass
force-pushed
the
18.06-vendor-buildkit
branch
3 times, most recently
from
fe8abfa to
50dc4d4
Compare
added 3 commits
July 20, 2018 23:48
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 0ab7c1c) Signed-off-by: Tibor Vass <tibor@docker.com>
This introduces a PRODUCT environment variable that is used to set a constant at dockerversion.ProductName. That is then used to set BuildKit's ExportedProduct variable in order to show useful error messages to users when a certain version of the product doesn't support a BuildKit feature. Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 195919d) Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 8159922) Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
18.06-vendor-buildkit
branch
from
50dc4d4 to
0832d1e
Compare
tiborvass
changed the title
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of moby#37439