This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] backport "Do not add duplicate platform information to service spec"#107
Merged
andrewhsu merged 2 commits intodocker-archive:17.06from Jul 12, 2017
andrewhsu:fix-service-spec
Merged
[17.06] backport "Do not add duplicate platform information to service spec"#107andrewhsu merged 2 commits intodocker-archive:17.06from andrewhsu:fix-service-spec
andrewhsu merged 2 commits intodocker-archive:17.06from
andrewhsu:fix-service-spec
Conversation
andrewhsu
changed the title
thaJeztah
approved these changes
Jul 12, 2017
|
The code duplication between the client library itself and the vendored copy in the same repo feels very strange to me. I do worry it will lead to mistakes in the future. But I understand that it's necessary with the current So LGTM, I guess. |
Contributor
|
In this case, isn't it true that only the code under |
docker-jenkins
pushed a commit
that referenced
this pull request
May 18, 2018
Make DOCKER_BUILD_PKGS reflective Upstream-commit: b523944 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 27, 2018
[18.09 backport] update libnetwork to fix iptables compatibility on debian Upstream-commit: 61a250fd23db8cee48403e3d9de5de100470bd03 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
[17.06] backport "Do not add duplicate platform information to service spec"
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.06] backport "Do not add duplicate platform information to service spec"
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Make DOCKER_BUILD_PKGS reflective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix:
With cherry-pick of moby/moby@da85b62: