X Tutup
Skip to content

Compose file v3.2#31795

Merged
dnephin merged 7 commits intomoby:masterfrom
dnephin:compose-file-v3.2
Mar 14, 2017
Merged

Compose file v3.2#31795
dnephin merged 7 commits intomoby:masterfrom
dnephin:compose-file-v3.2

Conversation

@dnephin
Copy link
Member

@dnephin dnephin commented Mar 13, 2017

Includes changes from #31112, and #30597

Revert the Compose file schema to the version that was released as v3.1
Add the new v3.2 schema with all the new changes

Compose PR for these schemas docker/compose#4616

cc @vdemeester @shin-

dnephin and others added 6 commits March 6, 2017 11:45
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Add a test for loading expanded mount format.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: allencloud <allen.sun@daocloud.io>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁
/cc @vieux @thaJeztah
@dnephin targeting 17.04 right ?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

I see @cpuguy83 had a question on #30597 (comment) so let's wait merging to be sure

@dnephin dnephin added this to the 17.04.0 milestone Mar 14, 2017
@dnephin
Copy link
Member Author

dnephin commented Mar 14, 2017

That PR is now merged, so merging this as well

@dnephin dnephin merged commit cd56476 into moby:master Mar 14, 2017
@dnephin dnephin deleted the compose-file-v3.2 branch March 14, 2017 18:10
dnephin added a commit to dnephin/docker that referenced this pull request Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup