X Tutup
Skip to content

Handle paused container when restoring without live-restore set#31704

Merged
crosbymichael merged 1 commit intomoby:masterfrom
mlaventure:handle-paused-container-on-non-live-restore
Mar 9, 2017
Merged

Handle paused container when restoring without live-restore set#31704
crosbymichael merged 1 commit intomoby:masterfrom
mlaventure:handle-paused-container-on-non-live-restore

Conversation

@mlaventure
Copy link
Contributor

Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com

--

Fixes #31699

@crosbymichael
Copy link
Contributor

Shouldn't we send the signal first then unpause?

Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
@mlaventure mlaventure force-pushed the handle-paused-container-on-non-live-restore branch from 58f293c to c458d3b Compare March 9, 2017 21:37
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure
Copy link
Contributor Author

@crosbymichael SIGTERM is sent before the call to Resume()

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this is effecting restart policy on restore, in that containers with restart=always are not restarting when the resume is required.

nevermind, that doesn't make sense, it was paused ;)

@crosbymichael
Copy link
Contributor

LGTM

@crosbymichael crosbymichael merged commit abb0fec into moby:master Mar 9, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 9, 2017
@mlaventure mlaventure deleted the handle-paused-container-on-non-live-restore branch March 10, 2017 00:00
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
This is cherry-picked from docker upstream PR:
  moby#31704

Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Signed-off-by: Deng Guangxing <dengguangxing@huawei.com>
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
- Bugfix: Increase udev wait timeout to 185s (mr 365)
- Bugfix: Add restarting check before attach a container (mr 362)
- Bugfix: daemon: reorder mounts before setting them (mr 350)
- Feature: modify centos rpm spec according to that of EulerOS (mr 361)
- Backport: fix TestDaemonRestartWithInvalidBasesize (mr 358)
- Backport: Ignore "failed to close stdin" if container or process not found (mr 364)
- Backport: Reset RemovalInProgress flag on daemon restart (mr 360)
- Backport: backport some prs after bumping containerd to v0.2.x branch (mr 342)
  - Fix restoring behavior when live-restore is not set (moby#24984)
  - Fix a race in libcontainerd/pausemonitor_linux.go (moby#26695)
  - Fix libcontainerd: attach streams before create (moby#26744)
  - add lock in libcontainerd client AddProcess (moby#27094)
  - Fix issues with fifos blocking on open (moby#27405)
  - inherit the daemon log options when creating containers (moby#21153)
  - Fix panic while merging log configs to nil map (moby#24548)
  - Move stdio attach from libcontainerd backend to callback (moby#27467)
  - Fix race on sending stdin close event (moby#28682)
  - Handle paused container when restoring without live-restore set (moby#31704)
  - Fix daemon panic on restoring containers (moby#25111)

Signed-off-by: Lei Jitang <leijitang@huawei.com>
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
bump to v1.11.2.19

- Bugfix: fix TestDaemonRestartWithInvalidBasesize (mr 358)
- Bugfix: Increase udev wait timeout to 185s (mr 365)
- Bugfix: Ignore "failed to close stdin" if container or process not found (mr 364)
- Bugfix: Add restarting check before attach a container (mr 362)
- Feature: modify centos rpm spec according to that of EulerOS (mr 361)
- Backport: daemon: reorder mounts before setting them (mr 350)
- Backport: Reset RemovalInProgress flag on daemon restart (mr 360)
- Backport: backport some prs after bumping containerd to v0.2.x branch (mr 342)
  - Fix restoring behavior when live-restore is not set (moby#24984)
  - Fix a race in libcontainerd/pausemonitor_linux.go (moby#26695)
  - Fix libcontainerd: attach streams before create (moby#26744)
  - add lock in libcontainerd client AddProcess (moby#27094)
  - Fix issues with fifos blocking on open (moby#27405)
  - inherit the daemon log options when creating containers (moby#21153)
  - Fix panic while merging log configs to nil map (moby#24548)
  - Move stdio attach from libcontainerd backend to callback (moby#27467)
  - Fix race on sending stdin close event (moby#28682)
  - Handle paused container when restoring without live-restore set (moby#31704)
  - Fix daemon panic on restoring containers (moby#25111)



Signed-off-by: Lei Jitang <leijitang@huawei.com>


See merge request docker/docker!366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup