Merged
Conversation
- Align output. Previously, output would end up unaligned because of longer task names (e.g. web.1 vs web.10) - Truncate task IDs and add a --no-trunc option - Added a --no-ids option to remove IDs altogether - Got rid of the generic ID Resolver as we need more customization. Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Signed-off-by: Drew Erny <drew.erny@docker.com>
dperny
force-pushed
the
service-logs-formatting
branch
from
ea31a07 to
83c34de
Compare
Contributor
Author
|
This PR supersedes #29197 and that PR can be closed. |
Contributor
Author
|
I don't believe the test failure is my fault. |
aluzzardi
added
the
priority/P1
Member
|
Tentatively targeting 17.04.0 |
vdemeester
approved these changes
Mar 10, 2017
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🦁
Experimental failure is a flaky test yeah 😓
Member
|
@cpuguy83 any feedback? |
Member
|
LGTM |
GordonTheTurtle
added
the
dco/no
Member
|
Damnit, hit the wrong button, no confirmations or anything... |
cpuguy83
force-pushed
the
service-logs-formatting
branch
from
da5d126 to
83c34de
Compare
GordonTheTurtle
removed
the
dco/no
Member
|
Ok, I fixed it. |
thaJeztah
added
impact/changelog
impact/cli
and removed
priority/P1
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Service logs formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates #29197 to address the concerns with that PR.
--detailsflag which isn't supported in the swarmkit API at this time. It may return later.paddingvariable on recommendation of @aaronlehmann.no-idstono-task-idsDoes this look good @aaronlehmann @cpuguy83 @vdemeester ?
/cc @aluzzardi