Fix docker version output alignment#965
Merged
vdemeester merged 1 commit intodocker:masterfrom Mar 28, 2018
Merged
Conversation
Member
Author
|
Or do we want "client" and "server" columns to be aligned? (guess we can do so by making the "min" width bigger) |
This was referenced Mar 26, 2018
dnephin
reviewed
Mar 26, 2018
cli/command/system/version.go
Outdated
| err = err2 | ||
| } | ||
| dockerCli.Out().Write([]byte{'\n'}) | ||
| buffer.WriteTo(t) |
Contributor
There was a problem hiding this comment.
Why do you need a buffer here? Can't you use t as the first arg to tmpl.Execute ?
Member
Author
There was a problem hiding this comment.
Oh! was debugging, looks like I don't need it here anymore no.
Use tabwriter to print the version output Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix-version-output
branch
from
69003e9 to
48eb7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #964
closes #769
closes #913
Use tabwriter to print the version output
@tiborvass I tried using a tab writer, and this seems to work correctly; do you know what bug you ran into?
Output with this change: