Codecov Report

Merging #882 into master will decrease coverage by 0.01%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   55.26%   55.25%   -0.02%     
==========================================
  Files         289      289              
  Lines       19385    19395      +10     
==========================================
+ Hits        10713    10716       +3     
- Misses       7977     7983       +6     
- Partials      695      696       +1

Do we have a good way to add a test for this?

Yes, it should be possible to unit test this with the fake client

Design LGTM, moving to code review based on the comments in the previous PR.

@dnephin PTAL

It wouldn't hurt to have a unit test for the new flag since it seems our coverage is low in this area

looks like a test was added

looks like a test was added

Well, it doesn't test anything really.. Having a bit of trouble with jsonmessage 😝 😅

ping @vdemeester were you still working on a test?

oh dang it, forgot about that one.

@thaJeztah updated 😉

@cpuguy83 @thaJeztah Updated, this add a new line to all docker pull like that.

Output (with/without -q) now looks like:

docker pull nginx:alpine
alpine: Pulling from library/nginx
Digest: sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196
Status: Image is up to date for nginx:alpine
docker.io/library/nginx:alpine

docker pull -q nginx:alpine
docker.io/library/nginx:alpine

• is it a concern that we output the fully-qualified name (with docker.io...)?
• would the digest be useful? i.e.; docker.io/library/nginx:alpine@sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196 (or docker.io/library/nginx@sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196 - without tag)?

The :tag@sha form would be helpful. It would have everything you could want in a compact reasonably computer parseable way.

The docker.io should go away if it doesn’t match the image name. That both docker pull and docker run should be able to use the returned string.

The docker.io should go away if it doesn’t match the image name. That both docker pull and docker run should be able to use the returned string.

@docwhat docker run and docker pull are able to run docker.io/library/nginx:alpine (it's just that docker has some default — hub — and special cases — library).

is it a concern that we output the fully-qualified name (with docker.io...)?

I don't think it's a concern as those can be used "as is" with the docker commandline (or containerd, …)

would the digest be useful?

Good point, I guess it would be even more useful indeed

I grok that. But if I pull nginx then I can run nginx.

If I add the namespace and host then docker run will go pull it again (though it’ll be fast since all the layers are already here).

Also docker image ls will show nginx without the namespace and host.

ping @vdemeester I forgot; what's the status on this one?

Bump, I've spent hours searching for a viable workaround to quiet down docker pull/push. Nothing seems to work with Semaphore CI. This would be a great feature to get in soon 👍

Please rebase @vdemeester 🦁

I'm on the same boat with @jregeimbal , It's very annoying to see the progress output in CI, We must press keycap page down twice or even more to ignore them over and over.

@thaJeztah updated (and rebased) 😉

oh, dang; one test needs updating;

--- FAIL: TestNewPullCommandSuccess (0.00s)
    pull_test.go:87: assertion failed: 
        --- expected
        +++ actual
        @@ -1,2 +1,3 @@
        +Using default tag: latest
         docker.io/library/image:latest