cli/command/container: deprecate NewStartOptions#4447
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jul 19, 2023
Merged
cli/command/container: deprecate NewStartOptions#4447thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
It's unused in the CLI itself, and does nothing other than initializing a new, empty StartOptions struct. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4447 +/- ##
=======================================
Coverage 59.40% 59.40%
=======================================
Files 288 288
Lines 24778 24778
=======================================
Hits 14719 14719
Misses 9173 9173
Partials 886 886 |
vvoland
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unused in the CLI itself, and does nothing other than initializing a new, empty StartOptions struct.
- A picture of a cute animal (not mandatory but encouraged)