add ability to override ints in compose files with 0#3812
Merged
thaJeztah merged 1 commit intodocker:masterfrom Dec 5, 2022
Merged
add ability to override ints in compose files with 0#3812thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Marco Spiess <marco.spiess@hotmail.de>
mspiess
force-pushed
the
3293-fix-replicas-override-0
branch
from
e014753 to
68330e0
Compare
thaJeztah
added
impact/changelog
status/2-code-review
area/stack
kind/bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3293
- What I did
Allow the number for
replicasto be overridden with 0 when using multiple compose files.- How I did it
I added a custom merge function for the type
*uint64. Maybe there is a more elegant way, but I was struggling to find documentation or examples for the used library "mergo". This issue of the library might be related.- How to verify it
See the reproduction steps in the linked issue.
- Description for the changelog
Fix overriding ints with 0 when using multiple compose files
🐳
Signed-off-by: Marco Spiess marco.spiess@hotmail.de